Skip to content

[CI] Restore MacOS test sanity #9120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion test/test_ops.py
Original file line number Diff line number Diff line change
Expand Up @@ -1201,11 +1201,30 @@ def test_forward_scriptability(self):
torch.jit.script(ops.DeformConv2d(in_channels=8, out_channels=8, kernel_size=3))


# NS: Remove me once backward is implemented for MPS
def xfail_if_mps(x):
mps_xfail_param = pytest.param("mps", marks=(pytest.mark.needs_mps, pytest.mark.xfail))
new_pytestmark = []
for mark in x.pytestmark:
if isinstance(mark, pytest.Mark) and mark.name == "parametrize":
if mark.args[0] == "device":
params = cpu_and_cuda() + (mps_xfail_param,)
new_pytestmark.append(pytest.mark.parametrize("device", params))
continue
new_pytestmark.append(mark)
x.__dict__["pytestmark"] = new_pytestmark
return x


optests.generate_opcheck_tests(
testcase=TestDeformConv,
namespaces=["torchvision"],
failures_dict_path=os.path.join(os.path.dirname(__file__), "optests_failures_dict.json"),
additional_decorators=[],
# Skip tests due to unimplemented backward
additional_decorators={
"test_aot_dispatch_dynamic__test_forward": [xfail_if_mps],
"test_autograd_registration__test_forward": [xfail_if_mps],
},
test_utils=OPTESTS,
)

Expand Down