Merged
Conversation
pmeier
approved these changes
Aug 10, 2023
Contributor
pmeier
left a comment
pmeier
left a comment
There was a problem hiding this comment.
Some comments inline. Nothing major so stamping to unblock.
NicolasHug
commented
Aug 10, 2023
| _transformed_types = (datapoints.Image, datapoints.Video, datapoints.Mask, datapoints.BoundingBoxes) | ||
|
|
||
| def _transform(self, inpt: Any, params: Dict[str, Any]) -> torch.Tensor: | ||
| return inpt.as_subclass(torch.Tensor) |
Member
Author
There was a problem hiding this comment.
I don't think we need / want a functional for this. The functional would just wrap .as_subclass(torch.Tensor) which is already public and users should just use that
pmeier
reviewed
Aug 10, 2023
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
vfdev-5
reviewed
Aug 10, 2023
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
Summary: Co-authored-by: Philip Meier <github.pmeier@posteo.de> Reviewed By: matteobettini Differential Revision: D48642260 fbshipit-source-id: c8f287816cc22508274c492703b6938fade169ad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @vfdev-5