Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7733
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 58b8eba: NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pmeier
commented
Jul 11, 2023
| def _gaussian_blur(self, kernel_size: List[int], sigma: Optional[List[float]] = None) -> Datapoint: | ||
| return self | ||
|
|
||
| def _normalize(self, mean: List[float], std: List[float], inplace: bool = False) -> Datapoint: |
Contributor
Author
There was a problem hiding this comment.
This was missed in #7113. We technically don't need it, since both the dispatcher
vision/torchvision/transforms/v2/functional/_misc.py
Lines 65 to 70 in 08c9938
and the transform
vision/torchvision/transforms/v2/_misc.py
Line 162 in 08c9938
filter on the datapoint type. However, this is the only dispatcher that does not have a method defined on the datapoint base class.
NicolasHug
approved these changes
Jul 11, 2023
Merged
Neilblaze
approved these changes
Jul 24, 2023
Contributor
Author
|
Superseded by #7747. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons:
Image(...).crop(...)and might think this is normal way to do it.Datapoint.resize, which overwritesTensor.resize. However, there might be more of these in the future.