Skip to content

port rotate#7713

Merged
pmeier merged 6 commits intopytorch:mainfrom
pmeier:port/rotate
Jul 3, 2023
Merged

port rotate#7713
pmeier merged 6 commits intopytorch:mainfrom
pmeier:port/rotate

Conversation

@pmeier
Copy link
Contributor

@pmeier pmeier commented Jun 30, 2023 •
edited by pytorch-bot bot
Loading

This PR also acts on #7703 (comment).

cc @vfdev-5

@pmeier pmeier requested a review from NicolasHug June 30, 2023 14:45
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 30, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7713

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 2 Unrelated Failures

As of commit 77866b9:

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base c3e9256:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pmeier
pmeier commented Jun 30, 2023
View reviewed changes
NicolasHug
NicolasHug reviewed Jun 30, 2023
View reviewed changes
NicolasHug
NicolasHug reviewed Jun 30, 2023
View reviewed changes
NicolasHug
NicolasHug approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier , LGTM when green

test/test_transforms_v2_refactored.py
elif input_type is PIL.Image.Image:
input = F.to_image_pil(input)
elif input_type is datapoints.BoundingBox:
kwargs.setdefault("format", datapoints.BoundingBoxFormat.XYXY)
Copy link
Member

@NicolasHug NicolasHug Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this logic be part of make_bounding_box's contract? (same for the dtype logic)

This is the kind of changes that makes me think we should already be moving away from the utils in common_utils for input generation, as suggested earlier #7562 (comment).

We can delay it but we'll have to do it eventually anyway, and IMO the earlier we do it, the more control we'll have.

Copy link
Contributor Author

@pmeier pmeier Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have a go at it after this PR before I port anything more.

Copy link
Contributor Author

@pmeier pmeier Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #7717

@pmeier pmeier merged commit 2d4484f into pytorch:main Jul 3, 2023
@pmeier pmeier deleted the port/rotate branch July 3, 2023 12:24
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier mentioned this pull request Jul 5, 2023
Merged
facebook-github-bot pushed a commit that referenced this pull request Aug 25, 2023
@NicolasHug @facebook-github-bot
[fbsync] port rotate (#7713)
de45a8b 
Reviewed By: matteobettini

Differential Revision: D48642318

fbshipit-source-id: dfcb7ca6a837104bc0acfe3ba2f66bb9ecef267b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees

No one assigned

Labels

cla signed module: tests module: transforms

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pmeier @NicolasHug @facebook-github-bot