remove obsolete transforms tests#7678
Merged
pmeier merged 2 commits intopytorch:mainfrom Jun 19, 2023
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7678
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit 965a5c5: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pmeier
added
module: transforms
module: tests
code quality
and removed
cla signed
labels
NicolasHug
approved these changes
Jun 19, 2023
|
|
||
|
|
||
| class TestRotate: | ||
|
|
Contributor
Author
There was a problem hiding this comment.
We are pinning the version
vision/.pre-commit-config.yaml
Line 18 in 8324c48
so let's hope this was just a fluke on my side. I'll revert these.
Contributor
Author
There was a problem hiding this comment.
It indeed comes from a newer black version that I have on my system. Since the removed blank lines don't conflict with the "old" style, it was not automatically reverted by running the pre-commit hook. I opened #7680 to upgrade our linters.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
Reviewed By: vmoens Differential Revision: D47186581 fbshipit-source-id: b7a147e32fa281fb29aef68319e25cb7491855b7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #7562 (comment) and confirmed in #7562 (comment), both tests deleted in this PR come from a time when we had our custom
interpolatekernels, since PyTorch core didn't support antialiasing. This is no longer the case and thus the tests are obsolete.cc @vfdev-5