Loosen overspecified type hints in functional

[qthequartermasterman]

In the transforms.functional module, many functions accept either an int or a sequence of ints (such as size parameters). These are correctly documented in the docstring, but the static type hints incorrectly mark them as List[int], which is too specific. This does not allow ints or Tuple[int], which are valid inputs.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7529

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

• Long queue for windows.4xlarge

❌ 18 Failures

As of commit ff81784:

NEW FAILURES - The following jobs have failed:

• build / linux-job (gh)
• python-source-and-configs / linux-job (gh)
• python-types / linux-job (gh)
• unittests (3.10, linux.12xlarge, cpu) / linux-job (gh)
• unittests (3.10, macos-12) / macos-job (gh)
• unittests (3.10, windows.4xlarge, cpu) / windows-job (gh)
• unittests (3.11, linux.12xlarge, cpu) / linux-job (gh)
• unittests (3.11, macos-12) / macos-job (gh)
• unittests (3.11, windows.4xlarge, cpu) / windows-job (gh)
• unittests (3.8, linux.12xlarge, cpu) / linux-job (gh)
• unittests (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.7) / linux-job (gh)
• unittests (3.8, macos-12) / macos-job (gh)
• unittests (3.8, macos-m1-12) / macos-job (gh)
• unittests (3.8, windows.4xlarge, cpu) / windows-job (gh)
• unittests (3.9, linux.12xlarge, cpu) / linux-job (gh)
• unittests (3.9, macos-12) / macos-job (gh)
• unittests (3.9, windows.4xlarge, cpu) / windows-job (gh)
• unittests-extended / linux-job (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[facebook-github-bot]

Hi @qthequartermasterman!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[pmeier]

Hey @qthequartermasterman. Believe me when I say that I desperately want this change, but unfortunately it breaks JIT. Sequence is not supported by it and thus we cannot use it.

The singular List[int] annotation stems from a time where JIT didn't even support Union. Since your goal is to "allow" int and Tuple[int, int] or the like as well, you can try a larger Union of these. However, JIT also has some undocumented automagic in the background that we sometimes rely upon. See #7252 for details. Meaning, I can't give you any guarantees that this will work. In turn, we can only accept such a PR when CI is fully green.