only return small set of targets by default from dataset wrapper#7488
Merged
pmeier merged 9 commits intopytorch:mainfrom Apr 6, 2023
Merged
only return small set of targets by default from dataset wrapper#7488pmeier merged 9 commits intopytorch:mainfrom
pmeier merged 9 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7488
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 FailuresAs of commit 47f638d: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
reviewed
Apr 3, 2023
NicolasHug
reviewed
Apr 3, 2023
pmeier
commented
Apr 6, 2023
Comment on lines
+774
to
+775
| area=float(torch.rand(1)), | ||
| iscrowd=int(torch.randint(2, size=(1,))), |
Contributor
Author
There was a problem hiding this comment.
We need the full sample now for target_keys="all".
NicolasHug
reviewed
Apr 6, 2023
Member
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks Philip, some comments below but looks good
Contributor
Author
|
Sneak peak into the performance gains of this change DetailsRoughly 3x over v1. To be fair, v1 is affected by #7489 so this comparison is not totally fair. However, it accurately reflects the current state of our references vs. what can be achieved with v2. |
This was referenced Apr 11, 2023
Closed
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
…pper (#7488) Reviewed By: vmoens Differential Revision: D45183665 fbshipit-source-id: 1d803dee2f2e1442113ad8d0e7f95e3b1314f7be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From benchmarking, it seems that the detection references with v2 are quite a bit slower than v1 for two reasons:
"segmentations"key, which stores the vertex coordinates of polygons in nested lists. Recursing through them every time withpytreeis slow."segmentations"key will be decoded into adatapoints.Maskand later on transformed although for regular object detection, this is not needed.This PR introduces the
target_keysparameter that let's users select which keys they actually want.ToDo:
"all"if users want everythingtarget_keysin all irregular datasets besidesCocoDetectioncc @vfdev-5