Added allowed_workflows to pytorch probot#7485
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7485
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 FailuresAs of commit c7d2255: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
.github/pytorch-probot.yml
Outdated
| @@ -1 +1,8 @@ | |||
| tracking_issue: 2447 | |||
| allowed_workflows: | |||
| - lint | |||
There was a problem hiding this comment.
Two questions here:
-
The lint workflows aren't flaky so why would we rerun them? Seems like a waste of resources.
-
For all the others we seem to use name of the workflow, e.g.
However, for the lint workflow we have
vision/.github/workflows/lint.yml
Line 1 in 78c2719
Is this case-insensitive? Even if so, could we use the "right" spelling here to avoid confusion?
There was a problem hiding this comment.
It is not case sensitive. I removed the lint workflow from the list. Once the configuration is moved to the domain repo, you guys decide which worker processes should be restarted.
| @@ -1 +1,8 @@ | |||
| tracking_issue: 2447 | |||
| allowed_workflows: | |||
There was a problem hiding this comment.
Could you add a comment what this actually does? Preferably with a permalink to the implementation of the bot that uses this.
| - Build Linux | ||
| - Build Macos | ||
| - Build M1 | ||
| - Tests on Linux | ||
| - Tests on macOS |
There was a problem hiding this comment.
If these are case-sensitive and basically just check job_name.startswith(allowed_workflow), shouldn't we be able to reduce this to
| - Build Linux | |
| - Build Macos | |
| - Build M1 | |
| - Tests on Linux | |
| - Tests on macOS | |
| - Build | |
| - Tests |
?
There was a problem hiding this comment.
I just prefer to be a bit more explicit. But again, this config should be maintained by domains. For now, I need it to be present. After, you can change it according to your needs or requirements.
pmeier
left a comment
pmeier
left a comment
There was a problem hiding this comment.
To summarize, all workflows going by the name: "..." attribute listed here, will be retried on the main branch in case they fail, right? Meaning, if we have flaky tests, the viable/strict branch can be updated anyway, correct?
|
No, the retry mechanism should work for all PRs. But there are some additional rules: the number of failed jobs should be less than 5 per workflow, retry can happen once for workflow. |
|
Hey @DanilBaibak! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Meaning just on PRs or on
Could you define "job" and "workflow" here? IIUC, "workflow" means a configuration file and a job is anything under the vision/.github/workflows/test-linux.yml Lines 12 to 13 in 715db1d Do jobs that use a matrix count as multiple ones or as one?
Does the retry happen on workflow or job level? Meaning, if I have a single failing job in a large workflow, will everything be retried or just the failing job? |
Reviewed By: vmoens Differential Revision: D45183678 fbshipit-source-id: d1fcbcf8d10c8acb3937b56804f77860b8eb946a
3 participants
Added allowed_workflows to pytorch probot. This is a follow up PR regarding the retry bot.
cc @seemethere