Skip to content

Remove old TODO about using _log_api_usage_once() #7277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Feb 17, 2023

I believe this TODO is now outdated as _log_api_usage_once() is called in the dispatcher kernels.

cc @vfdev-5

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it is outdated. See #7012. Thanks Nicolas!

@NicolasHug NicolasHug merged commit dfa81ce into pytorch:main Feb 17, 2023
facebook-github-bot pushed a commit that referenced this pull request Mar 28, 2023
Reviewed By: vmoens

Differential Revision: D44416602

fbshipit-source-id: 6e7101c39433c857ab0d1e9e0de1559b6a920610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants