fix {convert_format, clamp}_bounding_box #7229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two things that were missed in #7227 and #7228.
Calling a kernel should always be done by a plain tensor. Thus, we unwrap datapoints. Otherwise we are in hot water, because internally we assume that this is the case:
vision/torchvision/prototype/transforms/functional/_meta.py
Lines 246 to 248 in af7c6c0
Note that the call to
convert_format_bounding_box
will fail ifbounding_box
is adatapoint.BoundingBox
here, since we unconditionally pass theold_format
.After
convert_format_bounding_box
the format has to be updated and cannot be taken from the input by designcc @vfdev-5 @bjuncek