[proto] Some fixes for crestereo #6791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YosuaMichael
commented
Oct 18, 2022
| l_pyramid: Dict[str, Tensor] = {res: l_pyramid[idx] for idx, res in enumerate(self.resolutions)} | ||
| r_pyramid: Dict[str, Tensor] = {res: r_pyramid[idx] for idx, res in enumerate(self.resolutions)} | ||
| net_pyramid: Dict[str, Tensor] = {res: net_pyramid[idx] for idx, res in enumerate(self.resolutions)} | ||
| ctx_pyramid: Dict[str, Tensor] = {res: ctx_pyramid[idx] for idx, res in enumerate(self.resolutions)} |
There was a problem hiding this comment.
My local mypy complains:
crestereo.py:784: error: Name "l_pyramid" already defined on line 778
crestereo.py:785: error: Name "r_pyramid" already defined on line 779
crestereo.py:786: error: Name "net_pyramid" already defined on line 780
crestereo.py:787: error: Name "ctx_pyramid" already defined on line 781
Found 4 errors in 1 file (checked 1 source file)
and removing the type declaration seems to fix it.
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 21, 2022
Reviewed By: YosuaMichael Differential Revision: D40588159 fbshipit-source-id: a04a58a93a75ecd09223a970f4ec3333cc79d991
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nonefor theflow_initin the forward (so user no need to explicitly specify it)model = crestereo_base(weights="DEFAULT"))