Skip to content

don't fail linux CPU tests fast #6788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Oct 18, 2022

Without this, if one of the jobs fails, all other jobs will be aborted. That is usually not what we want. @osalpekar if this was intentional, feel free to close the PR.

Copy link
Member

@osalpekar osalpekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Catch - Thanks!

@pmeier pmeier merged commit f8b5a7a into pytorch:main Oct 18, 2022
@pmeier pmeier deleted the gha-cpu-fail-fast branch October 18, 2022 14:45
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Oct 21, 2022
Reviewed By: YosuaMichael

Differential Revision: D40588173

fbshipit-source-id: 955b3c165b535d382321fa0058981cdd92992645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants