-
Notifications
You must be signed in to change notification settings - Fork 7.1k
fix warnings in prototype transforms test suite #6785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2da1874
fix, ignore, or assert warnings for consistency tests
pmeier 8fec57e
fix, ignore, or assert warnings for kernel infos
pmeier 6bc915f
fix to_image_tensor for numpy inputs
pmeier ad137cf
make image from numpy contiguous
pmeier ac4a76f
fix test
pmeier bd47936
Merge branch 'main' into prototype-test-warnings
pmeier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1012,17 +1012,10 @@ def test_normalize_output_type(): | |
def test_to_image_tensor(inpt): | ||
output = F.to_image_tensor(inpt) | ||
assert isinstance(output, torch.Tensor) | ||
assert output.shape == (3, 32, 32) | ||
|
||
assert np.asarray(inpt).sum() == output.sum().item() | ||
|
||
if isinstance(inpt, PIL.Image.Image): | ||
# we can't check this option | ||
# as PIL -> numpy is always copying | ||
return | ||
|
||
inpt[0, 0, 0] = 11 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can no longer test this, since the |
||
assert output[0, 0, 0] == 11 | ||
|
||
|
||
@pytest.mark.parametrize( | ||
"inpt", | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these are throw-away tests anyway, I didn't bother to write a proper warnings handling on this test. All warnings here were deprecation warnings from us, so there is nothing to do besides ignoring anyway.