Skip to content

install torchdata from nightly releases in CI #5672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2022
Merged

install torchdata from nightly releases in CI #5672

merged 2 commits into from
Mar 24, 2022

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 24, 2022

As of today torchdata has an official nightly release. Thus, we can drop our workaround that installs from source.

@facebook-github-bot
Copy link

facebook-github-bot commented Mar 24, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit 298e6ea (more details on the Dr. CI page):

2 failures not recognized by patterns:

Job Step Action
CircleCI build_docs Build docs 🔁 rerun
CircleCI cmake_linux_gpu Build torchvision C++ distribution and test 🔁 rerun

🚧 3 ongoing upstream failures:

These were probably caused by upstream breakages that are not fixed yet.

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

NicolasHug
NicolasHug approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier , I'll approve to unblock but I have a question below regarding the change to torch nightly

.circleci/config.yml.in
@@ -146,7 +146,7 @@ commands:
default: true
steps:
- pip_install:
args: --pre torch -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
args: --pre torch --extra-index-url https://download.pytorch.org/whl/nightly/cpu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the recommended way of installing pytorch nightly?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, see https://pytorch.org/get-started/locally/. I don't know when this changed, but it seems the official way now.

@pmeier
Copy link
Collaborator Author

pmeier commented Mar 24, 2022

Not sure yet what is causing the docs failure, but I don't see it anywhere else. Don't merge.

@pmeier
Copy link
Collaborator Author

pmeier commented Mar 24, 2022

Failure comes from jinja2:

ImportError: cannot import name 'environmentfilter' from 'jinja2' (/home/circleci/project/env/lib/python3.7/site-packages/jinja2/__init__.py)

jinja2==3.1.0 was released about an hour ago. From the changelog:

environmentfilter and environmentfunction are replaced by pass_environment.

@pmeier
Copy link
Collaborator Author

pmeier commented Mar 24, 2022

Doc failure is unrelated. See #5673.

@pmeier pmeier merged commit 9e174d3 into pytorch:main Mar 24, 2022
facebook-github-bot pushed a commit that referenced this pull request Apr 5, 2022
@jdsgomes @facebook-github-bot
[fbsync] install torchdata from nightly releases in CI (#5672)
db9fa1d 
Summary: (Note: this ignores all push blocking failures!)

Reviewed By: datumbox

Differential Revision: D35216789

fbshipit-source-id: 3ec55d956012a54d210bd586db4e26107d72b0c0
@pmeier pmeier mentioned this pull request Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @facebook-github-bot @NicolasHug