Skip to content

Change default weights of RAFT model builders #5381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

NicolasHug
Copy link
Member

This changes the default of the RAFT model builders to rely on the more accurate C_T_SKHT_V2 weights, + some doc updates

@facebook-github-bot
Copy link

facebook-github-bot commented Feb 7, 2022

💊 CI failures summary and remediations

As of commit d786cf8 (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet.


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@NicolasHug NicolasHug added module: models other if you have no clue or if you will manually handle the PR in the release notes and removed cla signed labels Feb 7, 2022
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock but you need one more change, see below.

@NicolasHug NicolasHug merged commit 97eddc5 into pytorch:main Feb 7, 2022
facebook-github-bot pushed a commit that referenced this pull request Feb 11, 2022
Summary:
* Change default weights of RAFT model builders

* update handle_legacy_interface input

* Oops, wrong default

Reviewed By: NicolasHug

Differential Revision: D34140262

fbshipit-source-id: f233047c68d9179a7df4177fdb6a759af91ca34a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/default cla signed module: models other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants