Fix a bug and document RandomZoomOut #5278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 66bc73a (more details on the Dr. CI page):
1 failure not recognized by patterns:
1 job timed out:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
datumbox
added a commit
to datumbox/yolov5-rt-stack
that referenced
this pull request
Jan 25, 2022
|
@xiaohu2015 Sorry for getting ages to answer your question at #3403 (comment). I had to catch up with other things and forgot to check. This extra bit is indeed needed; I've added it to get around the limitation of PyTorch pad, which only accept integers for the |
zhiqwang
pushed a commit
to zhiqwang/yolort
that referenced
this pull request
Jan 25, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 3, 2022
Summary: Bug fix Reviewed By: kazhang Differential Revision: D33927496 fbshipit-source-id: 86d101f32a1bd3ba23e16f4ab102d1635265cf45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating a user question in relation to the RandomZoomOut transform at #3403 (comment), I noticed that the
torch.rand(1)check is flipped the other way around. It had no effects on the training of SSD because we usep=0.5but the bug needs to be fixed.Moreover I've added a comment to explain why an extra bit is necessary on the transform. I think the comment is necessary since I also have forgotten why the extra code is necessary and almost removed it.