Skip to content

add SVHN prototype dataset #5155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 20, 2022
Merged

add SVHN prototype dataset #5155

merged 5 commits into from
Jan 20, 2022

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Jan 3, 2022 •
edited by pytorch-probot bot
Loading

@pmeier pmeier requested a review from NicolasHug January 3, 2022 10:36
@facebook-github-bot
Copy link

facebook-github-bot commented Jan 3, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit 0f5a02b (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 2 ongoing upstream failures:

These were probably caused by upstream breakages that are not fixed yet.

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

NicolasHug
NicolasHug approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier ! I only took a quick look but LGTM, we'll make sure to add tests and potential fixed in follow up PRs

@pmeier
Copy link
Collaborator Author

pmeier commented Jan 17, 2022

Let's wait for #5187 to land and add tests here, since this PR is not urgent.

@pmeier pmeier merged commit 75af776 into pytorch:main Jan 20, 2022
@pmeier pmeier deleted the datasets/svhn branch January 20, 2022 15:22
facebook-github-bot pushed a commit that referenced this pull request Jan 26, 2022
@datumbox @facebook-github-bot
[fbsync] add SVHN prototype dataset (#5155)
dc3d569 
Summary:
* add SVHN prototype dataset

* add test

Reviewed By: jdsgomes, prabhat00155

Differential Revision: D33739392

fbshipit-source-id: 98249ce80f45e3d468cb8f18bc4472ee3818ff75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
ciflow/default cla signed module: datasets prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @facebook-github-bot @NicolasHug