Fix missing Torch includes #5118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit a2834ad (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
peterbell10
force-pushed
the
fix-includes
branch
from
1475c1e to
acec434
Compare
|
@peterbell10 Thanks for the PR. We are intentionally trying to be more selective on our includes. Can you adapt the PR to explicitly import those relevant missed includes rather than just importing |
|
|
datumbox
reviewed
Dec 22, 2021
|
Hey @datumbox! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 29, 2021
Summary: * Fix missing Torch includes * Import op_registration directly Reviewed By: prabhat00155 Differential Revision: D33351108 fbshipit-source-id: a97f347898867c535433a28c44ca886f65292dcd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
torchvisionbuild currently relies on transitive includes through unrelatedtorchheaders which is causing build failures in pytorch/pytorch#68693.