-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[FBcode->GH] Add import to fix linter error #5013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FBcode->GH] Add import to fix linter error #5013
Conversation
💊 CI failures summary and remediationsAs of commit de25166 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
The import fails in our tests. Should I remove the type annotation? cc @pmeier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this a FBcode=>GH sync and that eventually we will have to merge, just blocking to ensure we discuss it a bit.
I think the right way to address this would be to delete _get_confirm_token()
method which seems not being used. The requests
package was recently removed and I bet we missed clearing this method.
@pmeier could you please confirm?
If that's the case then we can merge the PR to sync internal/external and the follow up with one that removes the import and the private method completely.
Yeah, I don't see |
Exactly. I'll send a PR. |
@pmeier Don't send a PR. I'll update this PR after making the changes internally. This will simplify the internal sync. |
@prabhat00155 Updating this PR means we will need to export it via the script to sync it again. Because this is tagged as FBcode->GH it will be automatically excluded. So usually what we do (because it's the easiest way) is merge the original PR as-is and then fix the issue on a follow up PR which can easily be synced to FBcode. Would you be OK doing this? |
I have already made this change in the diff to fix the error. So, we won't need to sync this change again, hence the |
#4973 introduced a linter error internally(D32694312):