-
Notifications
You must be signed in to change notification settings - Fork 7.1k
support amp training for detection models #4933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit bfc9225 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @xiaohu2015!
There are some related linter issues, but overall it looks good.
@prabhat00155 could you have also a look since you did the classification one?
Co-authored-by: Vasilis Vryniotis <[email protected]>
Co-authored-by: Vasilis Vryniotis <[email protected]>
@datumbox Thanks. I have test the amp code, it works well. |
@xiaohu2015 There are a couple of more linter issues (spaces). Have a look a the CI job, at the end it will show you the errors. For your convenience here are the things you need to change to keep it happy:
Other than that, the changes look good to me. :) I'll leave it to @prabhat00155 to do the final checks on our side and merge when ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xiaohu2015!
Hey @prabhat00155! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
* support amp training * support amp training * support amp training * Update references/detection/train.py Co-authored-by: Vasilis Vryniotis <[email protected]> * Update references/detection/engine.py Co-authored-by: Vasilis Vryniotis <[email protected]> * fix lint issues Co-authored-by: Vasilis Vryniotis <[email protected]>
Summary: * support amp training * support amp training * support amp training * Update references/detection/train.py * Update references/detection/engine.py * fix lint issues Reviewed By: datumbox Differential Revision: D32470476 fbshipit-source-id: d0ef0c561b4eed2d0cf654741bd2d108ce65411e Co-authored-by: Vasilis Vryniotis <[email protected]> Co-authored-by: Vasilis Vryniotis <[email protected]> Co-authored-by: Vasilis Vryniotis <[email protected]>
The pr is about #4509.
Since amp is supported on classification training, I also modify some files to support amp training on detetction models.
cc @datumbox