Skip to content

Fix clang_format CI failure #4931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Fix clang_format CI failure #4931

merged 2 commits into from
Nov 15, 2021

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Nov 14, 2021

Fixes recent CI failures on the clang_format job caused by a missing lib.

cc @seemethere

@facebook-github-bot
Copy link

facebook-github-bot commented Nov 14, 2021

💊 CI failures summary and remediations

As of commit 6a83b33 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@datumbox datumbox changed the title [WIP] Fix clang_format CI failure Fix clang_format CI failure Nov 14, 2021
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @datumbox

@datumbox datumbox merged commit 4b20ac5 into pytorch:main Nov 15, 2021
@datumbox datumbox deleted the ci/fix_clang branch November 15, 2021 10:04
Copy link
Contributor

@jdsgomes jdsgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just would like to understand if it was working in the past and what was the change that broke the process?

@datumbox
Copy link
Contributor Author

@jdsgomes It was working in the past and broke at one point last week. Could be due to a change on the OS level. The dependency is no longer installed and it's now missing.

cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
facebook-github-bot pushed a commit that referenced this pull request Nov 17, 2021
Reviewed By: datumbox

Differential Revision: D32470480

fbshipit-source-id: 20850d26714f83b7705d1d810184d77e4abfeaa7
datumbox added a commit to datumbox/vision that referenced this pull request Dec 8, 2021
@datumbox datumbox mentioned this pull request Dec 8, 2021
datumbox added a commit that referenced this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants