Skip to content

Simplify the gradient clipping code #4896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2021

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Nov 10, 2021

As discussed at #4874 (comment)

@facebook-github-bot
Copy link

facebook-github-bot commented Nov 10, 2021

💊 CI failures summary and remediations

As of commit ef70ac0 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Contributor

@yiwen-song yiwen-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@datumbox datumbox merged commit 1de53be into pytorch:main Nov 12, 2021
@datumbox datumbox deleted the references/simplify_clipping branch November 12, 2021 18:18
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
facebook-github-bot pushed a commit that referenced this pull request Nov 17, 2021
Reviewed By: datumbox

Differential Revision: D32470478

fbshipit-source-id: e712637f0ab70edb61eb56489e1f4db036a99d5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants