Skip to content

Fix nvjpeg packaging into the wheel #4752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Fix nvjpeg packaging into the wheel #4752

merged 2 commits into from
Oct 26, 2021

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Oct 26, 2021

relocate fails to find nvjpeg unless it is present in the library search path.

Before the change, binary_linux_wheel_py3.8_cu113 nvjpeg.so.11 is skipped:

libnvjpeg.so.11
Omitting libnvjpeg.so.11

After the change binary_linux_wheel_py3.8_cu113 packages nvjpeg.so.11 into the wheel:

Update library dependencies
image.so: libpng16.so.16 -> libpng16.7f72a3c5.so.16
image.so: libjpeg.so.62 -> libjpeg.ceea7512.so.62
image.so: libnvjpeg.so.11 -> libnvjpeg.90286a3c.so.11
image.so: libcudart.so.11.0 -> libcudart.053364c0.so.11.0

@facebook-github-bot
Copy link

facebook-github-bot commented Oct 26, 2021

💊 CI failures summary and remediations

As of commit b219315 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@prabhat00155 prabhat00155 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @malfet, I have a comment/suggestion.

Relocate fails to find nvjpeg unless its present in the library search path.
@malfet malfet merged commit a078e6f into main Oct 26, 2021
@malfet malfet deleted the malfet-patch-1 branch October 26, 2021 16:34
@github-actions
Copy link

Hey @malfet!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

malfet added a commit that referenced this pull request Oct 26, 2021
Relocate fails to find nvjpeg unless its present in the library search path.
@seemethere seemethere added the bug label Oct 26, 2021
@malfet malfet linked an issue Oct 26, 2021 that may be closed by this pull request
facebook-github-bot pushed a commit that referenced this pull request Oct 27, 2021
Summary: Relocate fails to find nvjpeg unless its present in the library search path.

Reviewed By: NicolasHug

Differential Revision: D31957851

fbshipit-source-id: baf8cabb4f5d851f2be640aed86cb476ddc7ad2a
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
Relocate fails to find nvjpeg unless its present in the library search path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Torch ops unable to load "image.so"
5 participants