Skip to content

component_integration_tests: add aws_batch, ray + more interpretable #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Mar 1, 2022

This adds aws_batch and ray to the integration tests and refactors them to run per scheduler in parallel to make it clearer what's running.

Test plan:

CI + pyre

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 1, 2022
@d4l3k d4l3k force-pushed the integbatch branch 2 times, most recently from cc44abe to 210143a Compare March 1, 2022 20:43
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #403 (8940850) into main (571fd78) will decrease coverage by 0.12%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   94.54%   94.41%   -0.13%     
==========================================
  Files          66       66              
  Lines        3664     3670       +6     
==========================================
+ Hits         3464     3465       +1     
- Misses        200      205       +5     
Impacted Files Coverage Δ
torchx/components/dist.py 79.06% <ø> (+1.29%) ⬆️
torchx/schedulers/kubernetes_scheduler.py 92.67% <ø> (ø)
torchx/schedulers/aws_batch_scheduler.py 82.79% <37.50%> (-2.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 571fd78...8940850. Read the comment docs.

@d4l3k d4l3k force-pushed the integbatch branch 7 times, most recently from cd01835 to 6fdc375 Compare March 1, 2022 22:52
@d4l3k d4l3k changed the title component_integration_tests: add aws_batch + refactor component_integration_tests: add aws_batch, ray + more interpretable Mar 1, 2022
@d4l3k d4l3k force-pushed the integbatch branch 2 times, most recently from 03369b7 to e40671b Compare March 2, 2022 00:16
@facebook-github-bot
Copy link
Contributor

@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@d4l3k has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…403)

Summary:
This adds aws_batch and ray to the integration tests and refactors them to run per scheduler in parallel to make it clearer what's running.

Pull Request resolved: #403

Test Plan: CI + pyre

Reviewed By: kiukchung

Differential Revision: D34568682

Pulled By: d4l3k

fbshipit-source-id: 49357115c127d9033be47e19296eac6d662b618d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34568682

@d4l3k d4l3k deleted the integbatch branch April 13, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants