docker_workspace: support dockerignore to filter files from the workspace #401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a filter when building the docker workspace context to filter files specified in the
.dockerignore
file. This reduces the size of the patch when operating in a larger repo.Reference:
https://docs.docker.com/engine/reference/builder/#dockerignore-file
Next steps from this would be to extend this logic to be workspace agnostic so we could have a
.torchxignore
file but not sure if that makes sense or is strictly necessary yet.Test plan: