improve local scheduler log ordering #366
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This sets `PYTHONUNBUFFERED` to improve local scheduler logging latency. With this set each python log line gets immediately written out so you avoid large blocks of logs from the buffering. It also preserves groups unlike `readline()` since a stack trace will be written out as a single write There's can still be some small amount of ordering mismatches but it's better than it was before Differential Revision: D33433782 fbshipit-source-id: 0f39f86bfacd61b57c27df720046f50887c52a71
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D33433782 |
Codecov Report
@@ Coverage Diff @@
## main #366 +/- ##
=======================================
Coverage 94.62% 94.62%
=======================================
Files 61 61
Lines 3160 3161 +1
=======================================
+ Hits 2990 2991 +1
Misses 170 170
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This sets
PYTHONUNBUFFEREDto improve local scheduler logging latency. With this set each python log line gets immediately written out so you avoid large blocks of logs from the buffering. It also preserves groups unlikereadline()since a stack trace will be written out as a single writeThere's can still be some small amount of ordering mismatches but it's better than it was before
Differential Revision: D33433782