Skip to content

Move poll_trial_status and poll_available_capacity to TorchXRunner, remove TorchXScheduler #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aivanou
Copy link
Contributor

@aivanou aivanou commented Dec 13, 2021

Summary:
Adjusting the TorchX setup following D31031589 and D31032567
Deprecate torchx.runtime.hpo.ax.TorchXScheduler

Differential Revision: D33062113

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Dec 13, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D33062113

aivanou added a commit to aivanou/torchx-1 that referenced this pull request Feb 18, 2022
…er`, remove `TorchXScheduler` (pytorch#361)

Summary:
Pull Request resolved: pytorch#361

Adjusting the TorchX setup following D31031589 and D31032567
Deprecate `torchx.runtime.hpo.ax.TorchXScheduler`

Reviewed By: lena-kashtelyan

Differential Revision: D33062113

fbshipit-source-id: 1fa0003b96caa85925e6d70983ba6d0f791d02e3
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D33062113

aivanou added a commit to aivanou/torchx-1 that referenced this pull request Feb 18, 2022
…er`, remove `TorchXScheduler` (pytorch#361)

Summary:
Pull Request resolved: pytorch#361

Adjusting the TorchX setup following D31031589 and D31032567
Deprecate `torchx.runtime.hpo.ax.TorchXScheduler`

Reviewed By: lena-kashtelyan

Differential Revision: D33062113

fbshipit-source-id: 904a0a7572e3e7aa37500c5c4317879e9022f841
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D33062113

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #361 (a8a8930) into main (9784454) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
- Coverage   94.63%   94.62%   -0.01%     
==========================================
  Files          66       66              
  Lines        3560     3554       -6     
==========================================
- Hits         3369     3363       -6     
  Misses        191      191              
Impacted Files Coverage Δ
torchx/runtime/hpo/__init__.py 100.00% <ø> (ø)
torchx/runtime/hpo/ax.py 95.45% <100.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9784454...a8a8930. Read the comment docs.

…er`, remove `TorchXScheduler` (pytorch#361)

Summary:
Pull Request resolved: pytorch#361

Adjusting the TorchX setup following D31031589 and D31032567
Deprecate `torchx.runtime.hpo.ax.TorchXScheduler`

Reviewed By: lena-kashtelyan

Differential Revision: D33062113

fbshipit-source-id: 505f760f58341fc5046b2ef24be8514e32dbf117
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D33062113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants