Skip to content

CI: enable codecov coverage collection + cleanups #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Sep 30, 2021

  • enables coverage collection for python unit tests
  • uploads coverage to codecov.io
  • adds badge to README
  • updates README with instructions on how to install all dependencies
  • fixes finder_test compatibility with pytest

Test plan:

CI -- check coverage is correctly computed

2021-09-30-165142_1227x768_scrot
2021-09-30-165129_1350x366_scrot

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2021
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #214 (54cc105) into main (592c38b) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   90.90%   91.10%   +0.19%     
==========================================
  Files          97       57      -40     
  Lines        5247     2630    -2617     
==========================================
- Hits         4770     2396    -2374     
+ Misses        477      234     -243     
Impacted Files Coverage Δ
torchx/aws/util.py 0.00% <0.00%> (ø)
torchx/cli/colors.py 60.00% <0.00%> (ø)
torchx/apps/utils/test/booth_test.py
torchx/schedulers/test/ids_test.py
torchx/cli/test/main_test.py
torchx/components/component_test_base.py
torchx/pipelines/kfp/test/suites.py
torchx/runner/test/api_test.py
torchx/cli/test/cmd_runopts_test.py
torchx/runtime/tracking/test/api_test.py
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 592c38b...54cc105. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@d4l3k has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@d4l3k d4l3k deleted the codecov branch October 7, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants