Skip to content

DualPipeV schedule IR #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion torchtitan/distributed/pipeline_parallel.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
PipelineScheduleMulti,
PipelineScheduleSingle,
ScheduleZBVZeroBubble,
ScheduleDualPipeV,
)

from torchtitan.config import JobConfig
Expand Down Expand Up @@ -335,7 +336,7 @@ def _build_stage_from_modules(
models = []

schedule_class = get_schedule_class(pp_schedule)
style = "v" if schedule_class == ScheduleZBVZeroBubble else "loop"
style = "v" if schedule_class in (ScheduleZBVZeroBubble, ScheduleDualPipeV) else "loop"

for stage_idx in stage_ids_this_rank(pp_rank, pp_size, num_stages, style=style):
module_names = module_names_per_stage[stage_idx]
Expand Down
Loading