Fix VideoDecoder device argument to accept torch.device

[soheil-star01]

Summary

This PR fixes an issue where passing a torch.device to the VideoDecoder constructor causes a type error when passed to the underlying C++ add_video_stream function, which expects a str.

Changes

• Convert torch.device to str inside __init__ if necessary.

Why

Fixes bug #602: torch.device instances were not compatible with the expected C++ type (Optional[str]), causing decoding to fail.

Closes #602.

[facebook-github-bot]

Hi @soheil-star01!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[NicolasHug]

Thank you for the PR @soheil-star01 . Changes look good, before we merge could you please write a small non-regression test in https://github.com/pytorch/torchcodec/blob/main/test/decoders/test_decoders.py, to make sure that passing a torch.device() now works? Something as simple as this should be enough:

def test_device_instance(self):
	# Non-regression test for https://github.com/pytorch/torchcodec/issues/602	
	VideoDecoder(path, device=torch.device("cpu"))

[soheil-star01]

Thank you for the PR @soheil-star01 . Changes look good, before we merge could you please write a small non-regression test in https://github.com/pytorch/torchcodec/blob/main/test/decoders/test_decoders.py, to make sure that passing a torch.device() now works? Something as simple as this should be enough:

def test_device_instance(self):
	# Non-regression test for https://github.com/pytorch/torchcodec/issues/602	
	VideoDecoder(path, device=torch.device("cpu"))

@NicolasHug Thank you. Done!

[NicolasHug]

Thank you for the PR @soheil-star01 !