Merged
Conversation
facebook-github-bot
added
the
CLA Signed
seemethere
approved these changes
Aug 29, 2023
huydhn
approved these changes
Aug 29, 2023
|
@osalpekar is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Aug 30, 2023
There are more issues that I expect at the beginning: * Triton was uploaded on `main` instead of `nightly` and release branch * The environment `conda-aws-upload` wasn't used correctly in both wheel and conda upload * Conda update wasn't run in a separate ephemeral runner * Duplicated upload logic, should have just use `bash .circleci/scripts/binary_upload.sh` instead * Handle `CONDA_PYTORCHBOT_TOKEN` and `CONDA_PYTORCHBOT_TOKEN_TEST` tokens in a similar way as pytorch/test-infra#4530 Part of #108154 Pull Request resolved: #108187 Approved by: https://github.com/atalman
huydhn
added a commit
to huydhn/pytorch
that referenced
this pull request
Aug 30, 2023
There are more issues that I expect at the beginning: * Triton was uploaded on `main` instead of `nightly` and release branch * The environment `conda-aws-upload` wasn't used correctly in both wheel and conda upload * Conda update wasn't run in a separate ephemeral runner * Duplicated upload logic, should have just use `bash .circleci/scripts/binary_upload.sh` instead * Handle `CONDA_PYTORCHBOT_TOKEN` and `CONDA_PYTORCHBOT_TOKEN_TEST` tokens in a similar way as pytorch/test-infra#4530 Part of pytorch#108154
osalpekar
added a commit
that referenced
this pull request
Aug 30, 2023
Cherry-pick of #4530 onto release/2.1 branch
atalman
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Aug 30, 2023
There are more issues that I expect at the beginning: * Triton was uploaded on `main` instead of `nightly` and release branch * The environment `conda-aws-upload` wasn't used correctly in both wheel and conda upload * Conda update wasn't run in a separate ephemeral runner * Duplicated upload logic, should have just use `bash .circleci/scripts/binary_upload.sh` instead * Handle `CONDA_PYTORCHBOT_TOKEN` and `CONDA_PYTORCHBOT_TOKEN_TEST` tokens in a similar way as pytorch/test-infra#4530 Part of #108154
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will use a separate
CONDA_PYTORCHBOT_TOKEN_TESTfor using in a test environmentFixes #4529
TODO: