Update the Backward Compatibility Service Level Agreement (SLA) #35
Conversation
[ghstack-poisoned]
iseeyuan
requested review from
raziel,
gmagogsfm,
suo,
mruberry,
xcheng16,
dzhulgakov,
cccclai and
tugsbayasgalan
|
|
||
|
|
||
|
|
||
| * **OSS** — “stable” features will be deprecated for one release before a BC-breaking change is made. [PyTorch OSS BC-breaking policy](https://pytorch.org/docs/master/) | ||
| * **FB Internal** — we will not break a serialized torchscript program running in production at Facebook (to be replaced with a more generic SLA) | ||
| * PyTorch SLA will ensure that models developed using a cerntain version will be supported for *six months* from the version release date. |
There was a problem hiding this comment.
I think this is a bit more complex: we had discussed 1 release <= SLA <= 2 releases
So I think the wording we're looking for is along the lines of:
Socialize the 2-release (or 180 days since the BC-breaking change is made, whichever is later) SLA
| * PyTorch SLA will ensure that models developed using a cerntain version will be supported for *six months* from the version release date. | |
| * PyTorch SLA will ensure that models developed using a certain version and developed with non-deprecated APIs, will be runnable (with a slight performance regression allowed) for *up to one more release or 180 days* (from the version release date that introduced the BC-breaking change), whichever is later. |
Maybe it would be worth adding a couple of examples for the version and time based compatibility windows.
Good catch! Let me move to the proposal section and update the wording. |
…(SLA)" We are reaching to a consensus to an SLA window (6 months) for both mobile and server, both internal and OSS. Update it accordingly in this RFC. [ghstack-poisoned]
|
Thanks @iseeyuan Should we also call out as a goal/outcome that moving forward we're not having a difference between internal and OSS guarantees since they would be moving under the same SLA? Also, update the Facebook / FB references :-) |
Sounds good! Will call out the outcome, and update "Facebook". Thanks! |
…(SLA)" We are reaching to a consensus to an SLA window (6 months) for both mobile and server, both internal and OSS. Update it accordingly in this RFC. [ghstack-poisoned]
Stack from ghstack:
We are reaching to a consensus to an SLA window (6 months) for both mobile and server, both internal and OSS. Update it accordingly in this RFC.