Fix infinite loop in _validate_not_a_forked_repo()
#62072
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase `page_idx` in the loop rather than outside of it
Break from the loop when receive empty response as it means there are no
more items to fetch via pagination request
Fixes failure with "Rate Limit Exceeded" when doing something like `torch.hub.list("pytorch/test-infra:dsf")`
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 981a022 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mthrok
approved these changes
Jul 23, 2021
| if not response: | ||
| break | ||
| for br in response: | ||
| if br['name'] == branch or br['commit']['sha'].startswith(branch): |
There was a problem hiding this comment.
Note: Wonder if we should check the existence of the key. It's very unlikely to happen but we could give better error message.
There was a problem hiding this comment.
Good point let me address that
malfet
force-pushed
the
malfet/fix-loop-in-_validate_not_a_forked_repo
branch
from
acdfcfc to
981a022
Compare
|
Moved |
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
malfet
added a commit
to pytorch/builder
that referenced
this pull request
Sep 8, 2021
Example: ``` ./github_analyze.py --missing-in-branch --branch release/1.9 --milestone-id 23 URL;Title;Status https://github.com/pytorch/pytorch/pull/64036;[torch/elastic] Pretty print the failure message captured by @record;closed pytorch/pytorch#63953 torch.distributed.run OMP_NUM_THREADS message to log.warning;closed pytorch/pytorch#63910 Add torch.distributed.is_torchelastic_launched() util method + make init_method=tcp:// compatible with torchelastic;closed https://github.com/pytorch/pytorch/issues/62586;[v.1.9.1] Release Tracker ;open pytorch/pytorch#62378: Fix elastic launch doc;closed pytorch/pytorch#62139 option to skip GH validation for torch.hub;closed pytorch/pytorch#62072 infinite loop in `_validate_not_a_forked_repo()`;closed pytorch/pytorch#61394 mm not correctly report TORCH_CHECK failure issue;closed https://github.com/pytorch/pytorch/pull/61294;[torch] Various improvements to `torch.distributed.launch` and `torch.distributed.run` (#60925);closed pytorch/pytorch#60754 docs need an urgent serious update;closed pytorch/pytorch#60752 `torch.distributed.launch` issues in 1.9.0;closed https://github.com/pytorch/pytorch/issues/60717;torch.distributed.run future warning in 1.9.0;closed https://github.com/pytorch/pytorch/issues/60716;torch.distributed runs under INFO log level in 1.9.0;closed pytorch/pytorch#60318 Caffe2 thread-pool leak warning;closed pytorch/pytorch#60059 warning on .names() access in max_pool2d and max_pool2d_backward;closed pytorch/pytorch#58849 git stamp from release documentation version;open pytorch/pytorch#57555 function for skipping module parameter / buffer initialization;closed ```
malfet
added a commit
to malfet/pytorch
that referenced
this pull request
Sep 8, 2021
Summary:
Increase `page_idx` in the loop rather than outside of it
Break from the loop when receive empty response as it means there are no more items to fetch via pagination request
Also, add options to use provided github token (via `GITHUB_TOKEN` environment variable)
Fixes failure with "Rate Limit Exceeded" when doing something like `torch.hub.list("pytorch/test-infra:dsf")`
Fixes pytorch#61755
Pull Request resolved: pytorch#62072
Reviewed By: jbschlosser
Differential Revision: D29868539
Pulled By: malfet
fbshipit-source-id: 206082a0ba1208e9b15ff6c9c6cb71d2da74f1c3
This was referenced Sep 8, 2021
malfet
added a commit
that referenced
this pull request
Sep 8, 2021
Summary:
Increase `page_idx` in the loop rather than outside of it
Break from the loop when receive empty response as it means there are no more items to fetch via pagination request
Also, add options to use provided github token (via `GITHUB_TOKEN` environment variable)
Fixes failure with "Rate Limit Exceeded" when doing something like `torch.hub.list("pytorch/test-infra:dsf")`
Fixes #61755
Pull Request resolved: #62072
Reviewed By: jbschlosser
Differential Revision: D29868539
Pulled By: malfet
fbshipit-source-id: 206082a0ba1208e9b15ff6c9c6cb71d2da74f1c3
malfet
added a commit
to malfet/pytorch
that referenced
this pull request
Sep 8, 2021
Summary: Split from pytorch#62072 Pull Request resolved: pytorch#62139 Reviewed By: mthrok Differential Revision: D29891497 Pulled By: malfet fbshipit-source-id: 5c0baf53a2acf8f95062bd001457e1f936011529
malfet
added a commit
that referenced
this pull request
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase
page_idxin the loop rather than outside of itBreak from the loop when receive empty response as it means there are no more items to fetch via pagination request
Also, add options to use provided github token (via
GITHUB_TOKENenvironment variable)Fixes failure with "Rate Limit Exceeded" when doing something like
torch.hub.list("pytorch/test-infra:dsf")Fixes #61755