Support multiple config loaders coexisting#1281
Open
sanrise wants to merge 2 commits intopytorch:mainfrom
Open
Support multiple config loaders coexisting#1281sanrise wants to merge 2 commits intopytorch:mainfrom
sanrise wants to merge 2 commits intopytorch:mainfrom
Conversation
Summary: This implements Phase 1.1 of the lightweight on-demand GPU tracing system for Kubernetes environments. It provides an alternative to DaemonConfigLoader that receives trace configs via a TCP port instead of IPC Fabric, enabling GPU tracing in K8s pods without requiring a full Dynolog daemon. The PortConfigLoader implements the IDaemonConfigLoader interface with a simple JSON protocol (PING/TRACE commands) and includes a socket abstraction layer (ISocket) for testability. Unit tests use MockSocket to enable deterministic testing without binding to real ports. Differential Revision: D91278956
Summary: The previous single-slot design (`setDaemonConfigLoaderFactory`) only allowed one config loader at a time, making DaemonConfigLoader and PortConfigLoader mutually exclusive. This change enables both to coexist, which is necessary for hybrid environments where Kubernetes pods may use TCP-based tracing (PortConfigLoader) alongside Dynolog's IPC-based communication (DaemonConfigLoader). The ConfigLoader now maintains a vector of loaders and iterates through them, returning the first non-empty config. Test-only reset APIs are added (guarded by `KINETO_ENABLE_TEST_RESET_APIS`) to enable isolated unit testing of the singleton. Differential Revision: D91278953
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The previous single-slot design (
setDaemonConfigLoaderFactory) only allowed one config loader at a time, making DaemonConfigLoader and PortConfigLoader mutually exclusive. This change enables both to coexist, which is necessary for hybrid environments where Kubernetes pods may use TCP-based tracing (PortConfigLoader) alongside Dynolog's IPC-based communication (DaemonConfigLoader).The ConfigLoader now maintains a vector of loaders and iterates through them, returning the first non-empty config. Test-only reset APIs are added (guarded by
KINETO_ENABLE_TEST_RESET_APIS) to enable isolated unit testing of the singleton.Differential Revision: D91278953