[CUPTI] Do not clear out per-thread buffer flag #1115
Closed
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Aidyn-A the flag is being turned off after all of the profiling activity is disabled, so I believe it is safe in this case. |
Thanks for the quick response. My experiments show that it is still not safe call it after all activities are disabled. If clearing it out is a must, it is safe to do it after the flush. |
|
Ok sounds good lets add it to |
Aidyn-A
commented
Jul 21, 2025
|
@sraikund16 has imported this pull request. If you are a Meta employee, you can view this in D78676076. |
aaronenyeshi
approved these changes
Jul 22, 2025
|
@sraikund16 merged this pull request in 1928370. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation it is not safe to modify
CUPTI_ACTIVITY_ATTR_PER_THREAD_ACTIVITY_BUFFERattribute: "Changing this attribute in the middle of the profiling session will result in undefined behavior."