Skip to content

Cleanup CMake targets #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Cleanup CMake targets #1109

wants to merge 11 commits into from
+143 −225

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Jun 29, 2025 •
edited
Loading

There are some changes:

  1. Update minimum CMake version to 3.22 to use CUDA::cupti target to simplify code.
  2. Use CUDA::nvperf_host if the target is available (for CMake >=3.27), otherwise we create it.
  3. Fix Windows build errors.
  4. Fix XPU sources detection.
  5. Skip CUPTI tests on non-CUDA environments.
  6. Simplify KINETO_LIBRARY_TYPE handling.
  7. Don't install gtest targets.

Note: Windows shared builds don't work because no C++ symbol exported, this failure doesn't affect PyTorch builds because it always uses static builds.. This serious failure should be fixed in a later PR.

@cyyever cyyever marked this pull request as draft June 29, 2025 02:57
@sraikund16
Copy link
Contributor

Can you add a description?

@cyyever cyyever changed the title Cuda toolkit Use CUDA::nvperf_host, CUDA::cupti targets in CMake Jun 30, 2025
@cyyever cyyever marked this pull request as ready for review June 30, 2025 23:32
@cyyever cyyever marked this pull request as draft June 30, 2025 23:33
@cyyever cyyever force-pushed the cuda_toolkit branch 15 times, most recently from b5e5014 to d90e2b9 Compare July 3, 2025 09:21
@cyyever cyyever marked this pull request as ready for review July 3, 2025 09:32
@cyyever cyyever changed the title Use CUDA::nvperf_host, CUDA::cupti targets in CMake Use CUDA::cupti target in CMake code and bump gtest Jul 3, 2025
@facebook-github-bot
Copy link
Contributor

@sraikund16 has imported this pull request. If you are a Meta employee, you can view this in D77756382.

@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

@cyyever
Fix tests
fcf7be3 
Signed-off-by: cyy <[email protected]>
@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

@sraikund16
Copy link
Contributor

@cyyever still failing it looks like. Do you mind running the tests locally and then letting me know when it ready?

@cyyever
Copy link
Contributor Author

cyyever commented Jul 22, 2025

@sraikund16 It's interesting that I always pass locally..

@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

3 similar comments
@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

@cyyever
Fix tests
a4aa776 
Signed-off-by: cyy <[email protected]>
@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cyyever has updated the pull request. You must reimport the pull request before landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyyever @sraikund16 @facebook-github-bot