Skip to content

Conversation

@HyeSungP
Copy link
Contributor

@HyeSungP HyeSungP commented Mar 7, 2025

Related #3335

Description:
Added the available_device pytest fixture to test_mean_squared_error

P.S. This is my first contribution to this project.
Please let me know if there are any improvements I should make.
I appreciate any feedback!

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyeSungP thanks for the PR, looks good to me! Let's see if the CI on M1 with mps will pass. Once it is green we can merge the PR.

@vfdev-5 vfdev-5 merged commit 678405d into pytorch:master Mar 7, 2025
13 of 14 checks passed
@HyeSungP
Copy link
Contributor Author

HyeSungP commented Mar 8, 2025

@vfdev-5 Thank you for your kindness. I’m interested in this project and would like to contribute more. Would it be okay if I continue working on the remaining sub-issues of #3335? Or is there another issue you would recommend?

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 8, 2025

@HyeSungP yes you can continue helping with other subtasks from #3335 , there are plenty of them to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants