Skip to content

Conversation

@djwadhwa
Copy link
Contributor

Description: There are a few inline documentation citations that are not correct. I have used the associated whitepaper links provided to update the citation (including author and year)

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added examples Examples module: metrics Metrics module labels Nov 10, 2023
@sweep-ai-deprecated
Copy link
Contributor

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @djwadhwa , I left few comments to improve consistency in the info. Please address them

@djwadhwa
Copy link
Contributor Author

Thank you for pointing these out @vfdev-5! I have updated the documentation to align with the recommended changes.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @djwadhwa , lgtm!

@vfdev-5 vfdev-5 merged commit 30ceaf2 into pytorch:master Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples Examples module: metrics Metrics module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants