Skip to content

Fix mypy Type Error #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vfdev-5 merged 1 commit into from
Feb 10, 2023
Merged

Fix mypy Type Error #2854

vfdev-5 merged 1 commit into from
Feb 10, 2023

Conversation

@theory-in-progress
Copy link
Contributor

@theory-in-progress theory-in-progress commented Feb 10, 2023

Fixes mypy issue in workflow

Description:

  • Fixed the mypy type error because of tensorboard_logger.py for the nightly version
    Check list:
  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@theory-in-progress
Fix mypy Type Error
8df417d 
* Fixed the mypy type error because of tensorboard_logger.py for the nightly version
@github-actions github-actions bot added the module: contrib Contrib module label Feb 10, 2023
vfdev-5
vfdev-5 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @theory-in-progress !

@vfdev-5 vfdev-5 added this pull request to the merge queue Feb 10, 2023
@vfdev-5 vfdev-5 removed this pull request from the merge queue due to a manual request Feb 10, 2023
@vfdev-5 vfdev-5 added this pull request to the merge queue Feb 10, 2023
Merged via the queue into pytorch:master with commit 89d2930 Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

module: contrib Contrib module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theory-in-progress @vfdev-5