-
-
Notifications
You must be signed in to change notification settings - Fork 657
Add model_transform in create supervised trainer #2848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vfdev-5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guptaaryan16 thanks for the PR ! Looks good to me. Just few minor improvements and please add a test into https://github.com/pytorch/ignite/blob/master/tests/ignite/engine/test_create_supervised.py
|
cc @david-waterworth if case if you would like to review this PR |
|
@guptaaryan16 thanks for the update but let's improve test code |
|
@guptaaryan16 can you please update this PR to make it merged |
|
Hey @vfdev-5 , sure I am making the changes by today or tomorrow EOD and I apologise for the delay in the same |
|
Hey @vfdev-5 can you give me an idea on how to update the API doc |
|
@guptaaryan16 I pushed this PR : guptaaryan16#1 to your master branch on how to update the tests. Could you please merge this PR quickly to unblock this PR as we are planning the release. Thanks |
|
Okay I am working in this issue and hope to complete this today. Thanks for helping with the tests should I update the docs of the API |
Thanks @guptaaryan16 ! Can you add ignite/ignite/engine/__init__.py Lines 90 to 91 in d820c82
|
|
@vfdev-5 I don't know why but to make the tests work I had to remove the bias variable in the tests as it gives a NoneType error |
I checked the tests locally and they were passing. Let's revert this change and see the exact error message |
|
OK, I see, we have to remove all related lines: |
vfdev-5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @guptaaryan16
Fixes #2837
Description: I have added the function for model_transform
Check list: