Skip to content

Conversation

@sadra-barikbin
Copy link
Collaborator

In PR #2704 , in order to be able to have multiple groups in FastaiLRFinder when step_mode != 'exp', I suggested this code:
https://github.com/pytorch/ignite/pull/2704/files#r975195661

which uses ParamGroupScheduler. FastaiLRFinder calls get_param on its scheduler in

lr = self._lr_schedule.get_param() # type: ignore[union-attr]

but ParamGroupScheduler has not this method. This PR adds that method.

@github-actions github-actions bot added the module: handlers Core Handlers module label Sep 26, 2022
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sadra-barikbin
looks good to me.
Left a small comment on updating docstring

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Sep 27, 2022

I close and reopen the PR to restart the CI

@vfdev-5 vfdev-5 closed this Sep 27, 2022
@vfdev-5 vfdev-5 reopened this Sep 27, 2022
@sadra-barikbin
Copy link
Collaborator Author

@vfdev-5 , linkcheck job failed due to https://magellium.com link in docs. What is it?

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Sep 27, 2022

@sadra-barikbin it is from about.rst page: https://github.com/pytorch/ignite/blob/f9cd677de7aa87e9ecb9ad658c7170dddb85f444/docs/source/about.rst
we can ignore it for now if the failure remains we can remove the link

@vfdev-5 vfdev-5 merged commit f0f270d into pytorch:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: handlers Core Handlers module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants