Skip to content

Fixed unsupported torch quantile issue on test__base (#2697) #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vfdev-5 merged 4 commits into from
Sep 5, 2022
Merged

Fixed unsupported torch quantile issue on test__base (#2697) #2698

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ade1fec
Update test__base.py
puhuk Sep 5, 2022
c6744d8
Update test__base.py
puhuk Sep 5, 2022
65975f4
Update test__base.py
puhuk Sep 5, 2022
47540bf
Merge branch 'master' into issue_2697
vfdev-5 Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions tests/ignite/contrib/metrics/regression/test__base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,6 @@ def test_torch_median_numpy(size, device: Optional[str] = None):
assert _torch_median(data) == np.median(data.cpu().numpy())


@pytest.mark.parametrize("size", [101, (31, 3)])
def test_torch_median_quantile(size, device: Optional[str] = None):
data = torch.rand(size).to(device)
assert _torch_median(data) == torch.quantile(data, 0.5, interpolation="midpoint")

size = 101
data = torch.rand(size=(size,))
assert _torch_median(data) == torch.median(data)


@pytest.mark.tpu
@pytest.mark.parametrize("size", [100, 101, (30, 3), (31, 3)])
@pytest.mark.skipif(not idist.has_xla_support, reason="Skip if no PyTorch XLA package")
Expand All @@ -78,22 +68,3 @@ def test_on_even_size_gpu(size):
@pytest.mark.parametrize("size", [100, 101, (30, 3), (31, 3)])
def test_create_even_size_cpu(size):
test_torch_median_numpy(size, device="cpu")


@pytest.mark.tpu
@pytest.mark.parametrize("size", [101, (31, 3)])
@pytest.mark.skipif(not idist.has_xla_support, reason="Skip if no PyTorch XLA package")
def test_on_odd_size_xla(size):
device = "xla"
test_torch_median_quantile(size, device=device)


@pytest.mark.parametrize("size", [101, (31, 3)])
@pytest.mark.skipif(not torch.cuda.is_available(), reason="Skip if no GPU")
def test_on_odd_size_gpu(size):
test_torch_median_quantile(size, device="cuda")


@pytest.mark.parametrize("size", [101, (31, 3)])
def test_create_odd_size_cpu(size):
test_torch_median_quantile(size, device="cpu")