Rewritten Engine's terminate and terminate_epoch logic #2645

vfdev-5 · 2022-08-15T23:10:26Z

Description:

terminate() work on all events, called on catched _EngineTerminateException
terminate_epoch() work on iteration-based events, called on catched _EngineTerminateSingleEpochExpection
Fixed issue when attaching handlers on Events.TERMINATE_SINGLE_EPOCH
Added tests

Check list:

New tests are added (if a new feature is added)
New doc strings: description and/or example code are in RST format
Documentation is updated (if required)

@sadra-barikbin can you please review and comment out what do you think ?

…xception - terminate_epoch work on iteration-based events, called on catched _EngineTerminateSingleEpochExpection - Fixed issue when attaching handlers on Events.TERMINATE_SINGLE_EPOCH

ignite/engine/engine.py

…tion

ignite/engine/engine.py

vfdev-5 · 2022-08-18T10:12:43Z

@sadra-barikbin do you have any other remarks for this PR that could be blocking it for being merged ?

sadra-barikbin · 2022-08-18T16:18:44Z

@sadra-barikbin do you have any other remarks for this PR that could be blocking it for being merged ?

I finalize my review in a few minutes.

vfdev-5 · 2022-08-18T16:53:36Z

I finalize my review in a few minutes.

@sadra-barikbin have you submitted your review ?

ignite/engine/engine.py

tests/ignite/engine/test_engine.py

…e-terminate-and-co

vfdev-5 · 2022-08-22T20:56:18Z

@sadra-barikbin I updated the docs and tests etc. Please review it again. I want to merge it by tomorrow. Thanks

ignite/engine/engine.py

tests/ignite/engine/test_engine.py

vfdev-5 added 3 commits August 15, 2022 15:18

Added test_engine_run_resume

46cddf8

Terminate/Terminate Single Epoch work on all EPOCH/ITERATION events

f027a12

- terminate() work on all events, called on catched _EngineTerminateE…

8c36bfa

…xception - terminate_epoch work on iteration-based events, called on catched _EngineTerminateSingleEpochExpection - Fixed issue when attaching handlers on Events.TERMINATE_SINGLE_EPOCH

github-actions bot added the module: engine Engine module label Aug 15, 2022

vfdev-5 added 5 commits August 15, 2022 23:11

Updated docstring

4dc0a36

Merge branch 'master' into rewrite-engine-terminate-and-co

c4ee87b

Fixed issue with max_iters handling

24ab65f

Merge branch 'master' into rewrite-engine-terminate-and-co

c56de4c

Merge branch 'master' into rewrite-engine-terminate-and-co

b4fca31

vfdev-5 commented Aug 16, 2022

View reviewed changes