Skip to content

[BC-breaking] Fix ssim run on cuda 2532 #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vfdev-5 merged 39 commits into from
May 4, 2022
Merged

[BC-breaking] Fix ssim run on cuda 2532 #2564

vfdev-5 merged 39 commits into from
May 4, 2022

Conversation

@sadra-barikbin
Copy link
Collaborator

@sadra-barikbin sadra-barikbin commented May 4, 2022 •
edited by vfdev-5
Loading

Fixes #2532

Description:

  • Recoded update/compute methods : [BC-breaking] compute now return float instead of Tensor
  • Fix for master to be able to run on cuda

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

sadra-barikbin and others added 30 commits January 22, 2022 23:03
@sadra-barikbin
Remove unnecessary code in BaseOutputHandler
3484a59 
Closes pytorch#2438
@sadra-barikbin
Merge branch 'pytorch:master' into master
2c8eed9
@sadra-barikbin
Add ReduceLROnPlateauScheduler
ccf2364 
Closes pytorch#1754
@sadra-barikbin
Fix indentation issue
7f7dae6
@sadra-barikbin
Fix another indentation issue
896e482
@sadra-barikbin
Fix PEP8 related issues
cbc8d04
@sadra-barikbin
Fix other PEP8 related issues
47b0622
@sadra-barikbin
Fix hopefully the last PEP8 related issue
91d058e
@sadra-barikbin
Fix hopefully the last PEP8 related issue
9fd7d61
@sadra-barikbin
Merge branch 'pytorch:master' into master
b7dc921
@sadra-barikbin
Merge branch 'master' of https://github.com/sadra-barikbin/ignite
e0644e3
@sadra-barikbin
Remove ReduceLROnPlateau's specific params and add link to it
c95a2be 
Also fix bug in min_lr check
@sadra-barikbin
Fix state_dict bug and add a test
96554d0
@sadra-barikbin
Merge branch 'pytorch:master' into master
145dabc
@sadra-barikbin
Update docs
0aee28a
@vfdev-5
Merge branch 'master' into master
307803c
@sadra-barikbin
Merge branch 'pytorch:master' into master
0129572
@sadra-barikbin
Merge branch 'master' of https://github.com/pytorch/ignite
a17a5b2
@sadra-barikbin
Add doctest and fix typo
b3ea962
@sadra-barikbin
Merge branch 'master' of https://github.com/pytorch/ignite
e2e6831
@sadra-barikbin
Merge branch 'master' of https://github.com/pytorch/ignite
b88c9e1
@sadra-barikbin
Merge branch 'master' of https://github.com/sadra-barikbin/ignite
8d0ae3c
@vfdev-5
Merge branch 'master' into master
408b271
@sadra-barikbin
Merge branch 'master' of https://github.com/pytorch/ignite
102ba25
@sadra-barikbin
Merge branch 'master' of https://github.com/pytorch/ignite
a5d9bab
@sadra-barikbin
Merge branch 'master' of https://github.com/pytorch/ignite
8ad4113
@sadra-barikbin
Merge branch 'master' of https://github.com/pytorch/ignite
f4ba590
@sadra-barikbin
Merge branch 'master' of https://github.com/pytorch/ignite
c594fd7
@sadra-barikbin
Merge branch 'master' of https://github.com/pytorch/ignite
52dbb5c
@sadra-barikbin
Merge branch 'master' of https://github.com/pytorch/ignite
93ce080
@github-actions github-actions bot added the module: metrics Metrics module label May 4, 2022
@vfdev-5 vfdev-5 mentioned this pull request May 4, 2022
Closed
3 tasks
vfdev-5
vfdev-5 approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sadra-barikbin

@vfdev-5 vfdev-5 merged commit 315b6b9 into pytorch:master May 4, 2022
@vfdev-5 vfdev-5 changed the title Fix ssim run on cuda 2532 [BC-breaking] Fix ssim run on cuda 2532 May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

module: metrics Metrics module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SSIM update does not work for the last batch (if batch size is different)

2 participants

@sadra-barikbin @vfdev-5