Added: Improved tests using pytest parametrize #2543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se.py using pytest parametrize
Collaborator
|
@nmcguire101 thanks for the PR, however I'm not sure if this change is an improvement. This test with asserts I think does not require any reparametrization. You can also see that your PR removes 14 lines and adds 19 lines. |
vfdev-5
reviewed
Apr 9, 2022
vfdev-5
reviewed
Apr 11, 2022
nmcguire101
force-pushed
the
nmcguire101
branch
from
b6b511c to
a03cacc
Compare
vfdev-5
reviewed
Apr 14, 2022
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks for the update @nmcguire101
Few naming nits and good to go, I think
Co-authored-by: vfdev <[email protected]>
Co-authored-by: vfdev <[email protected]>
Co-authored-by: vfdev <[email protected]>
vfdev-5
approved these changes
Apr 14, 2022
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks @nmcguire101
LGTM
Collaborator
|
@nmcguire101 would you mind to apply similar ideas to other tests ? |
Contributor
Author
|
Yes, I will do that. Thank you for all your help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2522 (edited by @vfdev-5 to avoid closing the issue when this PR is merged)
Description:
Improved test tests\ignite\contrib\metrics\regression\test__base.py using pytest parametrize
Check list: