-
-
Notifications
You must be signed in to change notification settings - Fork 657
Add ReduceLROnPlateauScheduler feature #2449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sadra-barikbin thanks for the PR, can you run the following to fix code format:
See https://github.com/pytorch/ignite/blob/master/CONTRIBUTING.md#formatting-code |
5a4bfd1 to
06890ba
Compare
06890ba to
e0644e3
Compare
Also fix bug in min_lr check
2b753f7 to
c95a2be
Compare
2fd38f9 to
96554d0
Compare
|
Hi, @vfdev-5 Anything else should I do? |
|
Hi @sadra-barikbin thanks for updates, I left few other comments. I checked how it works and now i understand that you are patching an original private method : |
f159a56 to
cdadf6c
Compare
cdadf6c to
0aee28a
Compare
vfdev-5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sadra-barikbin thanks for the updates and sorry for delay !
Few nits about verbose and we can merge this PR.
|
@sadra-barikbin can you resolve conflicts with master and address remaining comments. We can try to merge it then. Thanks a lot ! |
8df9500 to
e2e6831
Compare
vfdev-5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @sadra-barikbin !
Good to the PR.
Fixes #1754
Description:
Add ReduceLROnPlateauScheduler which basically is a wrapper around
torch.optim.lr_scheduler.ReduceLROnPlateau. It supportsparam_group_indexandsave_historyparams.Check list: