[skip ci][skip actions][skip netlify] add run_code_style for windows
#2329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@sdesrozis thanks for the PR, can't we use bash scripts on windows as we probably be able to do on ci ? |
Contributor
Author
|
Yes, it works well with powershell. Using bash should be a good option, but it is not the usage in my company. Note that a win make.bat script is provided for documentation generation. I assumed that such scripts could be introduced as they really make the work easier. Anyway, it increases the maintenance, I completely understand if this PR is rejected. |
Collaborator
|
Ok for me to have it, thanks Sylvain ! |
fco-dv
pushed a commit
to fco-dv/ignite
that referenced
this pull request
Nov 23, 2021
Co-authored-by: Desroziers <[email protected]>
Ishan-Kumar2
pushed a commit
to Ishan-Kumar2/ignite
that referenced
this pull request
Dec 26, 2021
Co-authored-by: Desroziers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a Windows
cmdversion of the scriptrun_code_style. I'm not an expert of such a batch language but it seems to work pretty well as far I have tested.Check list: