[skipci] [Doctest] added contrib regression (FractionalBias, FractionalAbsoluteError, CanberraMetric, GeometricMeanAbsoluteError)
#2323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdesrozis
reviewed
Nov 12, 2021
sdesrozis
reviewed
Nov 12, 2021
sdesrozis
reviewed
Nov 12, 2021
sdesrozis
reviewed
Nov 12, 2021
sdesrozis
reviewed
Nov 12, 2021
ignite/contrib/metrics/regression/geometric_mean_absolute_error.py
Outdated
Show resolved
Hide resolved
Contributor
|
@Ishan-Kumar2 Thank you very much for your help. I left a few comments. Note that some tests are failing because of formatting (or a similar thing). |
sdesrozis
approved these changes
Nov 13, 2021
Contributor
sdesrozis
left a comment
sdesrozis
left a comment
There was a problem hiding this comment.
@Ishan-Kumar2 Thanks ! LGTM
51 tasks
fco-dv
pushed a commit
to fco-dv/ignite
that referenced
this pull request
Nov 23, 2021
…actionalAbsoluteError``, ``CanberraMetric``, ``GeometricMeanAbsoluteError``) (pytorch#2323) * added doctest for contrib regression metrics * removed Engine definition and variable name changes * added import of contrib.regression Co-authored-by: Sylvain Desroziers <[email protected]>
Ishan-Kumar2
added a commit
to Ishan-Kumar2/ignite
that referenced
this pull request
Dec 26, 2021
…actionalAbsoluteError``, ``CanberraMetric``, ``GeometricMeanAbsoluteError``) (pytorch#2323) * added doctest for contrib regression metrics * removed Engine definition and variable name changes * added import of contrib.regression Co-authored-by: Sylvain Desroziers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2265
Description:
Added Doctests for
FractionalBias,FractionalAbsoluteError,CanberraMetric,GeometricMeanAbsoluteErrorCheck list: