Skip to content

Make Checkpoint.load_objects to accept str and load internally (#2303) #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vfdev-5 merged 4 commits into from
Oct 29, 2021
Merged

Make Checkpoint.load_objects to accept str and load internally (#2303) #2305

vfdev-5 merged 4 commits into from
Oct 29, 2021

Conversation

@Abo7atm
Copy link
Contributor

@Abo7atm Abo7atm commented Oct 29, 2021 •
edited by vfdev-5
Loading

Fixes #2303

Description:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: handlers Core Handlers module label Oct 29, 2021
@vfdev-5 vfdev-5 self-requested a review October 29, 2021 13:29
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Oct 29, 2021

Thanks a lot for the PR @Abo7atm !
Could you please add a test for this new feature

@Abo7atm
Copy link
Contributor Author

Abo7atm commented Oct 29, 2021

Thanks for the help @vfdev-5! Added a test for the new feature.

vfdev-5
vfdev-5 reviewed Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @Abo7atm , I left few comments to address. Otherwise, looks good.

vfdev-5
vfdev-5 approved these changes Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @Abo7atm !

@vfdev-5 vfdev-5 merged commit fb6ba0a into pytorch:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

module: handlers Core Handlers module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make Checkpoint.load_objects to accept str and load internally

2 participants

@Abo7atm @vfdev-5