[DataPipe] Fix OnDiskCacheHolder to list all files for decompressing operations #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perations [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
ejguan
changed the title
…ompressing operations" Add `FileLister` to make sure `OnDiskCacheHolder` can list all of files after any 1-to-N operations like decompression. [ghstack-poisoned]
ejguan
commented
Feb 8, 2022
| @@ -137,6 +137,30 @@ def _read_and_decode(x): | |||
| self.assertTrue(os.path.exists(expected_csv_path)) | |||
| self.assertEqual(expected_csv_path, csv_path) | |||
|
|
|||
| # Cache decompressed archive but only check root directory | |||
There was a problem hiding this comment.
The following test won't pass with previous implementation.
…ompressing operations" Add `FileLister` to make sure `OnDiskCacheHolder` can list all of files after any 1-to-N operations like decompression. [ghstack-poisoned]
|
@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
VitalyFedyunin
approved these changes
Feb 9, 2022
…ompressing operations" Add `FileLister` to make sure `OnDiskCacheHolder` can list all of files after any 1-to-N operations like decompression. Differential Revision: [D34085743](https://our.internmc.facebook.com/intern/diff/D34085743) [ghstack-poisoned]
…ompressing operations" Add `FileLister` to make sure `OnDiskCacheHolder` can list all of files after any 1-to-N operations like decompression. Differential Revision: [D34085743](https://our.internmc.facebook.com/intern/diff/D34085743) [ghstack-poisoned]
|
@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ompressing operations" Add `FileLister` to make sure `OnDiskCacheHolder` can list all of files after any 1-to-N operations like decompression. Differential Revision: [D34085743](https://our.internmc.facebook.com/intern/diff/D34085743) [ghstack-poisoned]
|
@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ompressing operations" Add `FileLister` to make sure `OnDiskCacheHolder` can list all of files after any 1-to-N operations like decompression. Differential Revision: [D34085743](https://our.internmc.facebook.com/intern/diff/D34085743) [ghstack-poisoned]
|
@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Add
FileListerto make sureOnDiskCacheHoldercan list all of files after any 1-to-N operations like decompression.Differential Revision: D34085743